Simplify SweepSketch
#2454
Merged
Simplify SweepSketch
#2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SweepSketch` has two internal code paths. All models have so far been using the more complicated one. This commit updates them to instead use the more simple one, in preparation of removing the more complicated one.
Remove the more complicated code path, only leaving the simple ones. This puts more requirements on the caller, which I'm going to document in a follow-up commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The more complicated things that
SweepSketchdid got in the way of #2118, so I decided to take the practical approach and simplify it for now. This puts additional requirements on the callers, as per the new documentation.