Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly join triangles in BuildShell::tetrahedron #1778

Merged
merged 7 commits into from
Apr 21, 2023
Merged

Correctly join triangles in BuildShell::tetrahedron #1778

merged 7 commits into from
Apr 21, 2023

Commits on Apr 21, 2023

  1. Return HalfEdges in Triangle 

    `HalfEdge` references `GlobalEdge` (which was returned before), so this
is strictly more powerful. It causes some inconvenience, which I'm going
to address in future commits.
    @hannobraun
    hannobraun committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    6060c47 View commit details
    Browse the repository at this point in the history

  2. Don't join edges in BuildFace::triangle 

    Move that responsibility to its caller. This makes things a bit more
messy for now, but there are two extenuating circumstances:

1. It's necessary. The current approach to joining is insufficient, as
   it doesn't update the start vertex, and `BuildFace::triangle` doesn't
   have the information it needs to do it properly.
2. The new, repetitive code in `BuildShell::tetrahedron` can be factored
   into a new operations API, one specifically for joining.
    @hannobraun
    hannobraun committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    75e159d View commit details
    Browse the repository at this point in the history

  3. Update field names to match vertex order

    @hannobraun
    hannobraun committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    b652a2e View commit details
    Browse the repository at this point in the history

  4. Update doc comments

    @hannobraun
    hannobraun committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    137370f View commit details
    Browse the repository at this point in the history

  5. Add vertices to Triangle

    @hannobraun
    hannobraun committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    4b571b4 View commit details
    Browse the repository at this point in the history

  6. Refactor to prepare for follow-on change

    @hannobraun
    hannobraun committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    ee716b2 View commit details
    Browse the repository at this point in the history

  7. Correctly join triangles in tetrahedron 

    Previously, the start vertices were ignored when joining, not leading to
a correct result.
    @hannobraun
    hannobraun committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    9769fc2 View commit details
    Browse the repository at this point in the history