Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up objects service code #1715

Merged
merged 9 commits into from
Mar 22, 2023
Merged

Clean up objects service code #1715

merged 9 commits into from
Mar 22, 2023

Commits on Mar 22, 2023

  1. Remove unused code

    @hannobraun
    hannobraun committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    1cd918d View commit details
    Browse the repository at this point in the history

  2. Add missing re-exports

    @hannobraun
    hannobraun committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    2460b07 View commit details
    Browse the repository at this point in the history

  3. Update name of command

    @hannobraun
    hannobraun committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    0505d51 View commit details
    Browse the repository at this point in the history

  4. Simplify name of event

    @hannobraun
    hannobraun committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    9c5061e View commit details
    Browse the repository at this point in the history

  5. Refactor code to prepare for follow-on change

    @hannobraun
    hannobraun committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    6d6f32d View commit details
    Browse the repository at this point in the history

  6. Convert Operation into an enum

    @hannobraun
    hannobraun committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    c3c5f9e View commit details
    Browse the repository at this point in the history

  7. Remove unused trait implementation 

    It's getting in the way of adding complex operations, which I'm planning
to add in the form of a boxed trait. The boxed trait can't be
object-safe, if it needs to be `Clone`.
    @hannobraun
    hannobraun committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    2b36ea2 View commit details
    Browse the repository at this point in the history

  8. Inline redundant variable

    @hannobraun
    hannobraun committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    cb578fc View commit details
    Browse the repository at this point in the history

  9. Simplify ServiceObjectsExt::insert

    @hannobraun
    hannobraun committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    310a48e View commit details
    Browse the repository at this point in the history