Avoid creating duplicate GlobalCurves when transforming half-edge
#1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of addressing #1079,
GlobalCurvewill no longer contain geometric data, but instead just be an empty trait that only exists to determine whether two curves are different, or map to the sameGlobalCurve. This implies thatGlobalCurveequality no longer has any meaning, butGlobalCurveidentity does. I've written about this in more detail before.A lot of code created duplicate but equal
GlobalCurves. This happened to work, but is now turning into an error, as those duplicateGlobalCurves have different identities, which is going to trigger validation errors going soon. This pull request removes one source of duplicateGlobalCurves: the code that transforms half-edges. This is another step towards addressing #1079.