Start changing builder API into a partial object API #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new name describes what it is, while the old name ascribes a use case. Since I intend to use `PartialVertex` (and its other "builder" siblings) for other use cases too, the new name is more appropriate, I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reframe the previous vertex builders as partial vertices, update their API to be more flexible, and move them into the new
fj_kernel::partialmodule. Make the new partial vertex types more flexible than the old builders were.Partial objects are more broadly applicable, beyond their current use case. Namely, they will be required in the transform code (and probably more code beyond that), to address the new problems brought up by #1079 (see my comment about equality vs. identity there). The more flexible partial object API is a step towards addressing the object identity issues in the transform code, the current builder code itself, and possibly other code beyond that.