Expand sweep test suite #1077
Merged
Expand sweep test suite #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way I dealt with the sweep test suite in #1068 ended up not sitting quite right with me. The updated test suite was a bit weaker than the original one (well, before I started disabling some of the tests, so I could make progress on other things). The tests of one sweep implementation ended up using other sweep implementations, which I think is fine, but those other sweep implementations themselves didn't have test suites.
I've rectified that now. All the non-trivial
Sweepimplementations have test coverage now. I'm sure it doesn't cover all the edge cases that the code implements, but that's fine for now. All in all, we're in much better shape now than we were a while ago, when it comes to the sweep algorithm (both the clarity/quality of the code itself, as well as the test suite).cc @dwcarr, who has expressed interest in working on circular sweeps (#997)