Support directories as params, format with black, and add type hints #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanikesn
reviewed
Jul 18, 2022
| for subdir in source_dir.glob("**/"): # first subdir is the dir itself | ||
| if subdir == source_dir: | ||
| continue | ||
| discover_and_convert(subdir, target_dir / subdir.name) |
There was a problem hiding this comment.
Why the recursion and not just use source.dir.glob("**/*.woff") in the first place?
There was a problem hiding this comment.
Your question makes a lot of sense.
The only reason I opted for recursion is because I could keep the same directory structure in the output directory with no effort.
If the source directory looks like:
input_dir
subdir1
subdir11
subdir111
font.woffWith your approach and with no effort, the output dir would look like:
output_dir
font.otfIf you have a clean way of keeping the subdir structure, I'd happily apply it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.