Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental partial_match support. #32

Open
wants to merge 48 commits into
base: master
Choose a base branch
from
Open

Experimental partial_match support. #32

wants to merge 48 commits into from

Conversation

BenHanson
Copy link

Hi Hana, this is the first attempt.

@hanickadot
Copy link
Owner

Please fix the code so the tests will be green. Also add tests for new functionality.

@BenHanson
Copy link
Author

All the tests pass again and I have put in an early return, so the change should be much cleaner. I saw your comment about MSVC, but as the early return is conditional it looks OK.

@BenHanson BenHanson closed this Nov 5, 2018
@BenHanson BenHanson reopened this Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants