-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String manipulation functions added #259
base: main
Are you sure you want to change the base?
Conversation
What's the motivation for this change? Only usage for ctll::fixed_string is ability to store pattern in order to parse it. Also you can always just cast it into std::u32string_view and do the operations there. |
Im am working on my web framework and in it am using ctre for routing. |
What should i do now to get it to merge? |
Explain me why it needs to be part of CTRE and not your library. Seems like your functions are pretty standalone. What's the additional value for CTRE? |
It can be used to implement ctre::repace functionality and do compile time regex replacement. |
It's a lot of maybe. Nothing you are currently trying to add is needed for CTRE. I would prefer to merge or see complete |
Fair enough |
I desperately needed the ability to concatenate a ctll::fixed_string template parameter with a string literal in the template, and found this very useful as I didn't previously have any idea how to do that myself. I'm not trying to disagree with the idea that this doesn't need to be in the ctre package, but if it hadn't been in this pull request, I probably would have been pestering someone for assistance. |
I have added some basic functionality for compile-time manipulation such as find, count, split and replace.
If this poll request is accepted I will try to add compile-time regex::replace too.