Bundle install during hanami install #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This, in combination with our first-party gems (like hanami-rspec) updating their `after "install"` command hooks to become `before "install"`, will ensure that gems added to the Gemfile are installed as part of the initial `hanami new` command, rather than another manual `bundle install` being required afterwards.
timriley
force-pushed
the
bundle-install-during-hanami-install
branch
from
efe0b25
to
23b9c4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ensure that gems added to the
Gemfileby our first-party extensions (hanami-cli) are installed duringhanami new, rather than requiring the user to run their own manualbundle installafterwards.This requires the first-party extension gems to use a
before "install"command hook, instead of the currentafter "install".See also hanami/rspec#30
Fixes #265