Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ConflictingOptionsError #268

Closed
wants to merge 1 commit into from
Closed

Remove ConflictingOptionsError #268

wants to merge 1 commit into from

Conversation

cllns
Copy link
Member

@cllns cllns commented Nov 10, 2024 •
edited
Loading

Cleans up #266

Thanks for fixing this @timriley, it was my mistake.

@cllns cllns requested a review from timriley November 10, 2024 18:29
@timriley
Copy link
Member

@cllns Since this class is in 2.2.0 and marked as @api public, I'd be inclined to leave it there. It's not causing any harm, and it's the kind of thing I could see us wanting to use in the future, anyway. What do you think?

@cllns
Copy link
Member Author

cllns commented Nov 10, 2024

Yea that's fine! Sounds good

@cllns cllns closed this Nov 10, 2024
@timriley timriley deleted the remove-unused-error branch November 10, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timriley timriley Awaiting requested review from timriley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cllns @timriley