Fix: LinkClickHandler does not work when clicking a link in the markdown list #143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with the LinkClickHandler not working properly when a link is placed inside a markdown list, as in the example above.
I found that the process of parsing the markdown syntax and converting it to ASTs works recursively. In this case, if the type of AST node is
AstUnorderedList
orAstOrderedList
, it calls theFormattedList()
Composable function, which calls the BasicRichText function inside theFormattedList()
Composable function. However, the linkClickHandler parameter of theBasicRichText()
Composable function is not used, so theLinkClickHandler
registered by the user is not working properly. Rather, theLinkClickHandler
is becoming null.Inside the
FormattedList()
Composable function, I also modified theLocalLinkClickHandler
to accept a user-registeredLinkClickHandler
and pass it to theBasicRichText()
Composable function.Please review the modified code.
Thank you