Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CPack package naming when cross-compiling #8492

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

alexreinking
Copy link
Member

I expect this to work, but I need to get into the armbots to test it.

@alexreinking
Copy link
Member Author

Looks like ccache on one of the bots got messed up and there's a new LLVM 20 failure. This code doesn't run on the normal buildbots, so must be unrelated.

Copy link
Contributor

@steven-johnson steven-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green

EDIT: this won't actually test the nightlies which are affected, and there isn't a way to easily test the nightlies outside of the main branch, so we'll land this once we get a handful of greens as a realtiy check

@steven-johnson steven-johnson merged commit e5e2510 into main Dec 2, 2024
7 of 14 checks passed
@steven-johnson steven-johnson deleted the fix-cpack branch December 2, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants