Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use std::optional to clean up some code and prevent use-after-free bugs #8484

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Use std::optional to clean up some code and prevent use-after-free bugs #8484

wants to merge 6 commits into from

Commits on Nov 20, 2024

  1. Make as_const_* return a std::optional instead of a pointer 

    To prevent use-after-free bugs
    @abadams
    abadams committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    c8621a9 View commit details
    Browse the repository at this point in the history

  2. Also use std::optional for get_md_string and get_md_bool

    @abadams
    abadams committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    f605ec8 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into abadams/std_optional

    @abadams
    abadams committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    61e655c View commit details
    Browse the repository at this point in the history

  4. Fix some unchecked accesses, and turn off checking of the others (fal… 

    …se positives)
    @abadams
    abadams committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    0aa0c03 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Fix onnx converter, one unchecked use

    @abadams
    abadams committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    af079f0 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. return std::nullopt

    @abadams
    abadams committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    ba10097 View commit details
    Browse the repository at this point in the history