Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix navigateNext to start at top of next vertical stack #3575

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gchriz
Copy link
Contributor

@gchriz gchriz commented Feb 8, 2024

Some navigation issue regarding remembered vertical positions drove me crazy until I found out some details now.

After navigating left/right between vertical stacks below the top position and then continuing the presentation with Next (space or N) the presentation jumps from the bottom of current stack to the remembered position of the next stack to the right. And NOT to the top position as expected in the normal flow.
Navigating backwards (shift-space or P) is working correctly: The bottom slide of the next stack to the left is jumped to.

As far as I understand it the exact same behaviour is described in the older issue #2838.

So I fixed it in this PR.

(And I learned about npm etc. so that I was able to build reveal.js' "dist" directory.)

@gchriz
Copy link
Contributor Author

gchriz commented Feb 8, 2024

Probably the same fix needs to be applied one "else if" block above for config.rtl and so replacing the simple navigateLeft() there.
Since I don't know anything about RTL I didn't change that yet. But of course can do it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant