Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skip cache error #732

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix skip cache error #732

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcaf972
Fix skip cache error
Dec 24, 2024
390b55b
Delete token cache when failed to get email
Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions fileserver/sync_api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1283,13 +1283,15 @@ func validateToken(r *http.Request, repoID string, skipCache bool) (string, *app
}
}

if value, ok := tokenCache.Load(token); ok {
if info, ok := value.(*tokenInfo); ok {
if info.repoID != repoID {
msg := "Invalid token"
return "", &appError{nil, msg, http.StatusForbidden}
if !skipCache {
if value, ok := tokenCache.Load(token); ok {
if info, ok := value.(*tokenInfo); ok {
if info.repoID != repoID {
msg := "Invalid token"
return "", &appError{nil, msg, http.StatusForbidden}
}
return info.email, nil
}
return info.email, nil
}
}

Expand All @@ -1300,6 +1302,7 @@ func validateToken(r *http.Request, repoID string, skipCache bool) (string, *app
return email, &appError{err, "", http.StatusInternalServerError}
}
if email == "" {
tokenCache.Delete(token)
msg := fmt.Sprintf("Failed to get email by token %s", token)
return email, &appError{nil, msg, http.StatusForbidden}
}
Expand Down
Loading