Output error and warning log #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killing
reviewed
Nov 23, 2024
fileserver/fileop.go
Outdated
| @@ -763,7 +763,7 @@ func doBlock(rsp http.ResponseWriter, r *http.Request, repo *repomgr.Repo, fileI | |||
| err = blockmgr.Read(repo.StoreID, blkID, rsp) | |||
| if err != nil { | |||
| if !isNetworkErr(err) { | |||
| log.Printf("failed to read block %s: %v", blkID, err) | |||
| log.Warnf("failed to read block %s: %v", blkID, err) | |||
fileserver/fileop.go
Outdated
| return err | ||
| } | ||
| header := map[string][]string{ | ||
| "Authorization": {"Token " + token}, | ||
| } | ||
| _, _, err = utils.HttpCommon("POST", url, header, bytes.NewReader(msg)) | ||
| if err != nil { | ||
| log.Printf("failed to send repo update event: %v", err) | ||
| log.Errorf("failed to send repo update event: %v", err) |
There was a problem hiding this comment.
这个函数里面，发送通知失败属于不那么重要的错误，可以用 warn。
fileserver/fileop.go
Outdated
| @@ -1232,7 +1232,7 @@ func doUpload(rsp http.ResponseWriter, r *http.Request, fsm *recvData, isAjax bo | |||
| success := "{\"success\": true}" | |||
| _, err := rsp.Write([]byte(success)) | |||
| if err != nil { | |||
| log.Printf("failed to write data to response") | |||
| log.Warnf("failed to write data to response") | |||
fileserver/fileop.go
Outdated
| @@ -3015,7 +3015,7 @@ func doUpdate(rsp http.ResponseWriter, r *http.Request, fsm *recvData, isAjax bo | |||
| success := "{\"success\": true}" | |||
| _, err := rsp.Write([]byte(success)) | |||
| if err != nil { | |||
| log.Printf("failed to write data to response.\n") | |||
| log.Warnf("failed to write data to response.\n") | |||
fileserver/sync_api.go
Outdated
| @@ -851,7 +851,7 @@ func getBlockInfo(rsp http.ResponseWriter, r *http.Request) *appError { | |||
| rsp.Header().Set("Content-Length", blockLen) | |||
| if err := blockmgr.Read(storeID, blockID, rsp); err != nil { | |||
| if !isNetworkErr(err) { | |||
| log.Printf("failed to read block %s: %v", blockID, err) | |||
| log.Warnf("failed to read block %s: %v", blockID, err) | |||
fileserver/sync_api.go
Outdated
| @@ -914,7 +914,7 @@ func publishStatusEvent(rData *statusEventData) { | |||
| rData.eType, rData.user, | |||
| rData.repoID, rData.bytes) | |||
| if _, err := rpcclient.Call("publish_event", seafileServerChannelStats, buf); err != nil { | |||
| log.Printf("Failed to publish event: %v", err) | |||
| log.Errorf("Failed to publish event: %v", err) | |||
fileserver/sync_api.go
Outdated
| @@ -988,7 +988,7 @@ func getCommitInfo(rsp http.ResponseWriter, r *http.Request) *appError { | |||
| return appErr | |||
| } | |||
| if exists, _ := commitmgr.Exists(repoID, commitID); !exists { | |||
| log.Printf("%s:%s is missing", repoID, commitID) | |||
| log.Warnf("%s:%s is missing", repoID, commitID) | |||
fileserver/sync_api.go
Outdated
| @@ -1246,7 +1246,7 @@ func onRepoOper(eType, repoID, user, ip, clientName string) { | |||
| vInfo, err := repomgr.GetVirtualRepoInfo(repoID) | |||
|
|
|||
| if err != nil { | |||
| log.Printf("Failed to get virtual repo info by repo id %s: %v", repoID, err) | |||
| log.Warnf("Failed to get virtual repo info by repo id %s: %v", repoID, err) | |||
fileserver/sync_api.go
Outdated
| } | ||
| } | ||
|
|
||
| func publishUpdateEvent(repoID string, commitID string) { | ||
| buf := fmt.Sprintf("repo-update\t%s\t%s", repoID, commitID) | ||
| if _, err := rpcclient.Call("publish_event", seafileServerChannelEvent, buf); err != nil { | ||
| log.Printf("Failed to publish event: %v", err) | ||
| log.Errorf("Failed to publish event: %v", err) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.