Add json exp #699
Merged
Add json exp #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killing
reviewed
Sep 18, 2024
fileserver/utils/utils.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func GenJWTToken(repoID, user string, isInternal bool) (string, error) { |
There was a problem hiding this comment.
从逻辑上说，seahub internal API 的 jwt 和 notification server 的 jwt 是没有关系的。所以应该分为两个函数比较清晰。Claims 数据结构也应该分开。
fileserver/option/option.go
Outdated
|
|
||
| // seahub | ||
| SeahubURL string | ||
| PrivateKey string |
killing
reviewed
Sep 18, 2024
fileserver/utils/utils.go
Outdated
|
|
||
| func GenNotifJWTToken(repoID, user string) (string, error) { | ||
| claims := new(MyClaims) | ||
| claims.Exp = time.Now().Add(time.Hour * 72).Unix() |
killing
reviewed
Sep 18, 2024
fileserver/utils/utils.go
Outdated
|
|
||
| func GenNotifJWTToken(repoID, user string, exp int64) (string, error) { | ||
| claims := new(MyClaims) | ||
| claims.Exp = time.Now().Add(time.Hour * 72).Unix() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.