Add cookie to check share link access #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killing
reviewed
Sep 5, 2024
| cookie_header = g_strdup_printf ("Cookie: %s", cookie); | ||
| headers = curl_slist_append (headers, cookie_header); | ||
| g_free (cookie_header); | ||
| } |
There was a problem hiding this comment.
这个代码的位置往下面移动一下吧，感觉中断了 token_header 的代码。
server/http-tx-mgr.c
Outdated
| @@ -609,12 +610,17 @@ http_tx_manager_query_share_link_info (const char *token, const char *type) | |||
| curl = conn->curl; | |||
| headers = curl_slist_append (headers, "User-Agent: Seafile/"SEAFILE_CLIENT_VERSION" ("USER_AGENT_OS")"); | |||
There was a problem hiding this comment.
检查一下其他代码，这里的 User-Agent 应该改为 Seafile server 吧。
| header := map[string][]string{ | ||
| "Authorization": {"Token " + tokenString}, | ||
| } | ||
| if cookie != "" { | ||
| header["Cookie"] = []string{cookie} | ||
| } |
There was a problem hiding this comment.
这个请求没有设置 applicateion/json 的头部。可以在 HttpCommon 里面自动设置。HttpCommon 也需要增加请求超时。
killing
reviewed
Sep 6, 2024
server/http-tx-mgr.c
Outdated
| @@ -365,7 +365,7 @@ http_post (Connection *conn, const char *url, const char *token, | |||
|
|
|||
| curl = conn->curl; | |||
|
|
|||
| headers = curl_slist_append (headers, "User-Agent: Seafile/"SEAFILE_CLIENT_VERSION" ("USER_AGENT_OS")"); | |||
| headers = curl_slist_append (headers, "User-Agent: Seafile Server/"SEAFILE_CLIENT_VERSION" ("USER_AGENT_OS")"); | |||
There was a problem hiding this comment.
后面不用加 version 了，而且你这个也是客户端的版本。这些宏也删掉吧。
| @@ -20,7 +19,10 @@ func GetAuthorizationToken(h http.Header) string { | |||
| } | |||
|
|
|||
| func HttpCommon(method, url string, header map[string][]string, reader io.Reader) (int, []byte, error) { | |||
| req, err := http.NewRequestWithContext(HttpReqContext, method, url, reader) | |||
| header["Content-Type"] = []string{"application/json"} | |||
There was a problem hiding this comment.
这里设置了这个头部，就不用再调用 HttpCommon 之前设置了。多余的代码删除吧。
| "inline;filename=\"%s\"", filename); | ||
| } | ||
| snprintf(cont_filename, SEAF_PATH_MAX, | ||
| "inline;filename*=utf-8''%s;filename=\"%s\"", esc_filename, filename); |
There was a problem hiding this comment.
这个需要在 Chrome, Firefox 和 Safari 三个浏览器上测试。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.