Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last_modify field in form #666

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Add last_modify field in form #666

merged 4 commits into from
Jul 23, 2024

Conversation

feiniks
Copy link
Contributor

@feiniks feiniks commented Jul 16, 2024

No description provided.

Copy link
Member

@killing killing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

几点需要改的:

  1. post 需要支持为多个文件指定最后修改时间。multipart-formdata 并没有限制同一个名字的 field 不能出现多次。我们的代码在处理的时候只要要求 file field 的下一个 field 是最后修改时间就行了。可以把最后修改时间直接设置到临时文件上面。
  2. update file 也需要支持指定最后修改时间。
  3. 最后修改时间的格式应该用 RFC3339。

server/repo-op.c Outdated
@@ -48,6 +48,7 @@ post_files_and_gen_commit (GList *filenames,
const char *user,
char **ret_json,
int replace_existed,
gint64 mtime,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个参数应该放在最后。

@killing killing merged commit 6c056c1 into master Jul 23, 2024
2 checks passed
@killing killing deleted the add_mtime branch July 23, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants