Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the inability to move files with special characters #656

Merged
merged 4 commits into from
May 6, 2024
Merged

Conversation

feiniks
Copy link
Contributor

@feiniks feiniks commented Apr 20, 2024

No description provided.

@killing
Copy link
Member

killing commented Apr 29, 2024

现在 del_file, move_file, copy_file 三个 rpc 的参数文档和检查和 json 格式不匹配。

  • api.py 里面的注释要改一下
  • rpc 实现函数里面,参数检查的逻辑要改一下。

Copy link
Member

@killing killing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seaf_repo_manager_copy_multiple_files 这些函数处理参数错误的时候,应该返回 SEAF_ERR_BAD_ARGS,并且也不用打印日志。

@@ -296,14 +296,14 @@ def put_file(self, repo_id, tmp_file_path, parent_dir, filename,

'''
If you want to delete multiple files in a batch, @filename should be in
the following format: 'filename1\tfilename2\tfilename3'
the following format: '["filename1", "filename2", "filename3"]'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不用给格式例子了,直接说用 JSON array 格式输入。

@killing killing merged commit 4ca723d into 11.0 May 6, 2024
2 checks passed
@killing killing deleted the fix_move_file branch May 6, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants