Update python to 3.12.8 for ci test (#729)

* Update python to 3.12.8 for ci test * Fix error for notification server --------- Co-authored-by: 杨赫然 <[email protected]>
haiwen · Dec 19, 2024 · db8c637 · db8c637
1 parent da31024
commit db8c637
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -12,7 +12,7 @@ jobs:
           fetch-depth: 1
       - uses: actions/setup-python@v1
         with:
-          python-version: "3.8"
+          python-version: "3.12.8"
       - name: install dependencies and test
         run: |
           cd $GITHUB_WORKSPACE

diff --git a/ci/run.py b/ci/run.py
@@ -54,8 +54,8 @@ def _env_add(*a, **kw):
 
     _env_add('PATH', join(PREFIX, 'bin'))
     if on_github_actions():
-        _env_add('PYTHONPATH', join(os.environ.get('RUNNER_TOOL_CACHE'), 'Python/3.8.14/x64/lib/python3.8/site-packages'))
-    _env_add('PYTHONPATH', join(PREFIX, 'lib/python3.8/site-packages'))
+        _env_add('PYTHONPATH', join(os.environ.get('RUNNER_TOOL_CACHE'), 'Python/3.12.8/x64/lib/python3.12/site-packages'))
+    _env_add('PYTHONPATH', join(PREFIX, 'lib/python3.12/site-packages'))
     _env_add('PKG_CONFIG_PATH', join(PREFIX, 'lib', 'pkgconfig'))
     _env_add('PKG_CONFIG_PATH', join(PREFIX, 'lib64', 'pkgconfig'))
     _env_add('PKG_CONFIG_PATH', libsearpc_dir)

diff --git a/notification-server/server.go b/notification-server/server.go
@@ -10,8 +10,8 @@ import (
 	"os"
 	"os/signal"
 	"path/filepath"
-	"strings"
 	"strconv"
+	"strings"
 	"syscall"
 	"time"
 
@@ -46,7 +46,7 @@ func init() {
 }
 
 func loadNotifConfig() {
-	host := os.Getenv("NOTIFICATION_SERVER_HOST")
+	host = os.Getenv("NOTIFICATION_SERVER_HOST")
 	if host == "" {
 		host = "0.0.0.0"
 	}
@@ -55,7 +55,7 @@ func loadNotifConfig() {
 	if os.Getenv("NOTIFICATION_SERVER_PORT") != "" {
 		i, err := strconv.Atoi(os.Getenv("NOTIFICATION_SERVER_PORT"))
 		if err == nil {
-			port = i
+			port = uint32(i)
 		}
 	}