Add ETag for access file (#664)

Co-authored-by: 杨赫然 <[email protected]>
haiwen · Jul 9, 2024 · 49168a1 · 49168a1
1 parent 4ca723d
commit 49168a1
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/fileserver/fileop.go b/fileserver/fileop.go
@@ -149,6 +149,7 @@ func accessCB(rsp http.ResponseWriter, r *http.Request) *appError {
 	}
 
 	now := time.Now()
+	rsp.Header().Set("ETag", objID)
 	rsp.Header().Set("Last-Modified", now.Format("Mon, 2 Jan 2006 15:04:05 GMT"))
 	rsp.Header().Set("Cache-Control", "max-age=3600")
 

diff --git a/server/access-file.c b/server/access-file.c
@@ -1110,6 +1110,16 @@ start_download_zip_file (evhtp_request_t *req, const char *token,
     return 0;
 }
 
+static void
+set_etag (evhtp_request_t *req,
+          const char *file_id)
+{
+    evhtp_kv_t *kv;
+
+    kv = evhtp_kv_new ("ETag", file_id, 1, 1);
+    evhtp_kvs_add_kv (req->headers_out, kv);
+}
+
 static gboolean
 can_use_cached_content (evhtp_request_t *req)
 {
@@ -1300,6 +1310,8 @@ access_cb(evhtp_request_t *req, void *arg)
         goto on_error;
     }
 
+    set_etag (req, data);
+
     if (can_use_cached_content (req)) {
         goto success;
     }