General cleanup #483
Closed
General cleanup #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a statement on what we will try to do to get more people using Haiku for research purposes.
…eam.md Co-authored-by: humdinger <[email protected]>
Fixed typos, added alert warning for API design and kernel work, and also moved heading types up by one, since H2 wasn't being used.
|
I think all pages on the website start at h3, not sure why however. |
pulkomandy
reviewed
Mar 22, 2021
|
|
||
| <ul> | ||
| <li>Skill set: userland development, exploring a large code-base (WebCore)</li> | ||
| <li>Possible mentors/knowledgeable people: PulkoMandy</li> | ||
| <li><a href="https://github.com/haiku/haikuwebkit/pull/4">Sourcecode of GSoC 2019 work</a></li> | ||
| <li><a href="https://github.com/haiku/webkit">Sourcecode (see the webkit2 branch)</a></li> |
There was a problem hiding this comment.
You have undone one of my fixes here. haiku/haikuwebkit#4 is the correct URL
pulkomandy
reviewed
Mar 22, 2021
| distributed under the GPL license. We would prefer to use Apple implementation, | ||
| which is under 3 clause BSD, more suitable for us.</p> | ||
| distributed under the GPL license. We would prefer to use Apple's implementation, | ||
| which is under the 3 clause BSD license, which is a more suitable license for us.</p> |
There was a problem hiding this comment.
the double "which is" and repetition of "license" here doesn't make this really better
pulkomandy
reviewed
Mar 22, 2021
| <li><a href="http://en.wikipedia.org/wiki/Xfs">XFS</a> (<a href="http://xfs.org/index.php/Main_Page">Development community</a>, <a href="http://oss.sgi.com/projects/xfs/index.html">homepage</a>) is a filesystem originally developed for the IRIX operating system. Today it is commonly used by Haiku developers who build Haiku from Linux, because of its better support for extended filesystem attributes (unlike ext4). | ||
|
|
||
| Update: You are recommended to look at the current status of XFS. We are in the process of merging XFS v2. XFS v3 has been out for a long time and bringing read support for it could be a better idea before jumping to providing write support. This may require some discussion and we encourage you to reach out to us.</li> | ||
| <li><a href="http://en.wikipedia.org/wiki/Xfs">XFS</a> (<a href="http://xfs.org/index.php/Main_Page">Development community</a>, <a href="http://oss.sgi.com/projects/xfs/index.html">homepage</a>) is a filesystem originally developed for the IRIX operating system. Today it is commonly used by Haiku developers who build Haiku from Linux, because of its better support for extended filesystem attributes (unlike ext4).</li> |
There was a problem hiding this comment.
here you have removed a previous update.
also please add linebreaks when you change long lines like this, because it is impossible to read the changes in github
pulkomandy
reviewed
Mar 22, 2021
| @@ -579,20 +567,20 @@ <h4><img src="/images/App_Generic_32.png"/> | |||
|
|
|||
| <ul> | |||
| <li>Skill set: IPv4 and IPv6 protocols, kernel and network stack development</li> | |||
| <li>Possible mentors: </li> | |||
| <li>Possible mentors: jua</li> | |||
There was a problem hiding this comment.
you have reverted previous changes
pulkomandy
reviewed
Mar 22, 2021
| @@ -753,33 +741,33 @@ <h4><img src="/images/App_Generic_32.png"/> | |||
|
|
|||
| <ul> | |||
| <li>Skill set: general C/C++, userland development</li> | |||
| <li>Possible mentors: </li> | |||
| <li>Possible mentors: jua</li> | |||
There was a problem hiding this comment.
you have reverted previous changes here. Jua is not available to mentor this year.
|
@pulkomandy Whoops - I think I must have done this before rebasing my Master branch. I'll probably close this pull request, redo the changes above and then open a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed typos, added alert warning for API design and kernel work, and also moved all heading types up by one, since H2 wasn't being used.