Banking message changes #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ediately or banked in the future pending review.
|
oooh, this is an interesting approach! I like that you're thinking about this @warmpigman. deferring to @techpixel for review |
|
talked to you on slack about it, but the |
|
Will test this on my end |
|
sorry I haven't gotten around to this - if you can bring this up to date with main, I'll properly test this & merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change banking message to inform user whether they will be banked immediately or banked in the future pending review.
https://hackclub.slack.com/archives/C077TSWKER0/p1718772657963829