Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpu: add option "no_compute" to forcibly disable the use of compute shaders #262

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ruihe774
Copy link
Contributor

See mpv-player/mpv#14163

Also worth noting some GPUs have better performance with fragment shaders than compute shaders. For example my Intel DG2 [Arc A750] on Linux.

@haasn
Copy link
Owner

haasn commented May 17, 2024

It may be better to handle this on the pl_gpu level, by disabling the compute capability outright. Or adding a capability to prefer fragment shaders over compute shaders.

@kasper93
Copy link
Contributor

kasper93 commented May 17, 2024

Related https://code.videolan.org/videolan/libplacebo/-/issues/310 I would prefer some sort of "detection", because while option will allow users to control that, how user can know if they should disable it?

@norinoriko
Copy link

Auto-detection wouldn't really benefit people who do get better performance with compute shaders, but want to disable it for other reasons (like power usage). So I still think there's value in exposing such an option to users.

@ruihe774 ruihe774 changed the title renderer: add option "no_compute" to forcibly disable the use of compute shaders gpu: add option "no_compute" to forcibly disable the use of compute shaders May 18, 2024
@ruihe774 ruihe774 marked this pull request as ready for review May 18, 2024 16:59
to forcibly disable the use of compute shaders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants