Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: skip sonarqube step for PR from form #109 #156

Merged
merged 8 commits into from
Jul 16, 2024
Merged

ci: skip sonarqube step for PR from form #109 #156

merged 8 commits into from
Jul 16, 2024

Conversation

CAMOBAP
Copy link
Collaborator

@CAMOBAP CAMOBAP commented Jul 2, 2024

#111 PR looks too complex and hard to maintain. I propose alternative solution for the same problem

@CAMOBAP CAMOBAP requested a review from DSergiu July 2, 2024 08:59
@CAMOBAP CAMOBAP self-assigned this Jul 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024 •
edited
Loading

Diffuse report:

OLD: sdk-main.aar
NEW: sdk-pr.aar

 AAR      │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────
      jar │  51.7 KiB │  51.7 KiB │  0 B 
 manifest │     411 B │     411 B │  0 B 
      res │  78.3 KiB │  78.3 KiB │  0 B 
    other │     954 B │     954 B │  0 B 
──────────┼───────────┼───────────┼──────
    total │ 131.3 KiB │ 131.3 KiB │  0 B 

 JAR     │ old │ new │ diff      
─────────┼─────┼─────┼───────────
 classes │  37 │  37 │ 0 (+0 -0) 
 methods │ 507 │ 507 │ 0 (+0 -0) 
  fields │ 162 │ 162 │ 0 (+0 -0)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024 •
edited
Loading

Benchmark report:

Test name Time ms. (median) Allocations (median)
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerification +337.07 -7
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerificationColdRun +389.13 +99
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleSetup -0.14 +96
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugInfo -5.56 +556
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugSys +24.12 +1

@CAMOBAP
ci: use fresh AVD from benchmark tests (#157)
124caaa
@CAMOBAP
refactor: build gradle (#161)
6cd1223 
* chore: split big sdk/build.gradle to several applied gradle sripts

* chore: upload all outputs and reports on benchmark failure

* ci: move timeout restoriction to step level and reduce it to 20

* debug: enable artifact upload for success bench

* fix: ignore HCaptchaWebViewHelperTest.benchmarkWebViewLoad benchmark
@CAMOBAP
ci: skip sonarqube step for PR from form #109
1a87021
@CAMOBAP
ci: migrate to own check-user-permission action
57aa7fd
@CAMOBAP
Merge branch 'ci/skip-sonarqube-for-for-prs' of github.com:hCaptcha/h…
e3e5848 
…captcha-android-sdk into ci/skip-sonarqube-for-for-prs
@CAMOBAP
fix: bad prior merge
130b2e9
@CAMOBAP
fix: add value to outputs of check-user-permission action
66a630b
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@CAMOBAP
Copy link
Collaborator Author

CAMOBAP commented Jul 14, 2024

@DSergiu migrated to own check-user-permission action

@CAMOBAP CAMOBAP merged commit 73df5de into main Jul 16, 2024
12 checks passed
@CAMOBAP CAMOBAP deleted the ci/skip-sonarqube-for-for-prs branch July 16, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSergiu DSergiu DSergiu approved these changes

Assignees

@CAMOBAP CAMOBAP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CAMOBAP @DSergiu