New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for partial derivatives #13

Draft

gdgirard wants to merge 26 commits into main from gdgirard_10-partial-derivatives-of-a-2d-field_2

Member

gdgirard commented Dec 13, 2024

No description provided.

gdgirard and others added 9 commits

December 12, 2024 12:14


          Adding of the math_tools/ folder and renaming od utils/math_tools.hpp…

4342fb8

… into math_tools/Lnorm_tools.hpp


          Modification of the title comment.

9e3387e


          Rename file Lnorm_tools.hpp -> l_norm_tools.hpp

cf02192


          Merge branch 'main' into gdgirard_10-partial-derivatives-of-a-2d-field

faef937


          Remove dead link

0727d78


          Rename tests/utils/test_math_tools.cpp into tests/math_tools/test_lno…

8a5c51b

…rm_tools.cpp.


          Add missing README.md.

8b5b68b


          [GEOM TOKAMAXI] Add partial_derivatives.hpp.

9be6573


          Add computation of max error for test_partial_derivatives.

648f9c5

gdgirard had a problem deploying to development

December 13, 2024 07:41

— with

GitHub Actions Error

gdgirard marked this pull request as draft

December 13, 2024 07:42

EmilyBourne and others added 5 commits

December 13, 2024 09:09


          The SplineBuilder must be batched

78ca751


          Add missing return

ae00a5d


          Correct the test on partial derivatives.

53e1472


          Merge branch 'main' into gdgirard_10-partial-derivatives-of-a-2d-field_2

0dfaf0a


          Fix markdown problems.

599f139

EmilyBourne reviewed

View reviewed changes

src/math_tools/partial_derivatives.hpp Outdated Show resolved Hide resolved

EmilyBourne reviewed

View reviewed changes

src/math_tools/partial_derivatives.hpp Show resolved Hide resolved

EmilyBourne reviewed

View reviewed changes

src/math_tools/partial_derivatives.hpp Outdated Show resolved Hide resolved

EmilyBourne reviewed

View reviewed changes

src/math_tools/README.md Outdated Show resolved Hide resolved

EmilyBourne reviewed

View reviewed changes

tests/math_tools/CMakeLists.txt Outdated Show resolved Hide resolved

EmilyBourne reviewed

View reviewed changes

tests/math_tools/test_partial_derivatives.cpp Outdated Show resolved Hide resolved

EmilyBourne reviewed

View reviewed changes

tests/timestepper/CMakeLists.txt Outdated Show resolved Hide resolved

gdgirard and others added 7 commits

December 13, 2024 11:04


          Generalisation of partial derivatives to more than 2D.

ca24c18


          Add static assert.

f5efa98


          Update src/math_tools/README.md

aa8dd43

Co-authored-by: Emily Bourne <[email protected]>


          Apply suggestions from code review

a7b9d22

Co-authored-by: Emily Bourne <[email protected]>


          Delete unuseful comment

68e23ee

Co-authored-by: Emily Bourne <[email protected]>


          Add missing comments in class PartialDerivative.

509e7b5


          Correct the indentation.

90e55ea


          Correct comments.

92c5a3c

gdgirard marked this pull request as ready for review

December 13, 2024 11:04

gdgirard had a problem deploying to development

December 13, 2024 11:04

— with

GitHub Actions Error

github-actions bot commented Dec 13, 2024

This PR is failing tests so it has been put back into draft. Please remove the draft status when the tests pass.

github-actions bot marked this pull request as draft

December 13, 2024 11:04


          Add missing compilation flags

698786e

EmilyBourne marked this pull request as ready for review

December 13, 2024 12:41

EmilyBourne had a problem deploying to development

December 13, 2024 12:41

— with

GitHub Actions Error

github-actions bot marked this pull request as draft

December 13, 2024 12:41

github-actions bot commented Dec 13, 2024

This PR is failing tests so it has been put back into draft. Please remove the draft status when the tests pass.

EmilyBourne added 2 commits

December 13, 2024 14:10


          Allow MPI to run as root (this is fine inside a docker)

d3b8a9d


          Merge branch 'main' into gdgirard_10-partial-derivatives-of-a-2d-field_2

212cbfb

EmilyBourne marked this pull request as ready for review

December 13, 2024 13:11

EmilyBourne had a problem deploying to development

December 13, 2024 13:12

— with

GitHub Actions Error

github-actions bot commented Dec 13, 2024

It seems like you haven't finished working on this PR so it has been put back into draft. Please remove the draft status when the PR can run tests without being interrupted.

github-actions bot marked this pull request as draft

December 13, 2024 14:27


          Fix indentation

975e67e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet