Add generic home page section generation #175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarekPikula
force-pushed
the
variable-sections
branch
4 times, most recently
from
f5c6f9d
to
488c25b
Compare
|
Hi @MarekPikula , Thanks for all your valuable pull requests ❤️ . All your pull requests can make this template to use in more effective way. |
|
As it involves more changes, I will check this pull request clearly and merge. |
|
Sure thing. The main issue I have with this PR in particular is that it introduces braking changes. I thought about making it backwards-compatible, but couldn't find a way to do it cleanly (yet). I'd say that we have a few options:
What do you think? |
MarekPikula
force-pushed
the
variable-sections
branch
from
488c25b
to
589091a
Compare
|
I just rebased the branch onto the recent master, so that it's directly mergable. |
This change enables theme user to specify arbitrary order of sections, and add multiple sections of the same type (more generic approach than in gurusabarish#105, which is applicable only to experience blocks). - All sections are specified in config as a list, with order of items directly reflecting order on the main page (including navbar). - Type of a section is specified with a new `type` field. - If there are multiple sections of the same type, in order to distinguish them for navbar navigation, you need to specify unique `id` field. - Navbar and main page generation is more generic, allowing to add custom section types – the only requirement is a custom partial named after the section type. Styling can be provided in a custom CSS (enabled with `customCSS` site param). Signed-off-by: Marek Pikuła <[email protected]>
MarekPikula
force-pushed
the
variable-sections
branch
from
589091a
to
de3bd30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables theme user to specify arbitrary order of sections, and add multiple sections of the same type (more generic approach than in #105, which is applicable only to experience blocks).
typefield.idfield.customCSSsite param).