Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 — Update to node current LTS (20.12.2) and core dependencies #23

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

mchv
Copy link
Member

@mchv mchv commented May 7, 2024

What does this change?

The associated changes update the action to run on node 20.12.2 as well as the core dependencies. Presented in a logical order:

  • Commit 055e492 — Upgrade of node as version 16 has reached end of life, and Github actions should be upgraded.
  • Commit c0ab742 — Update of core dependencies, notably guardian cdk, typescript, es-lint to the latest compatible version
  • Commit af8b43f — Update of generated infrastructure code as a result of those dependencies update.
  • Commit bc59741 — Remove an unused import
  • Commit af4cc68 — Fix latest vulnerability, upgrading only package-lock.json

As the result of those upgrade:

  • ✅ the typescript compiler, linter and tests are now running successfully (they are failing on main branch 🙀)
  • ✅ all reported dependency vulnerabilities are fixed
  • ✅ no warning when running the action
  • ✅ next dependencies upgrade should be much easier
  • 📝 all dependants who will update their workflow to version 3 of this action will have their infra benefit from the guardian cdk upgrade.

How to test?

I think that once this branch build, I should be able to reference it in a existing action and verify that it works before we release a version 3, but I am not certain.

How can we measure success?

  • The action is running on a supported runtime
  • 9 open security vulnerabilities all fixed

@mchv mchv requested a review from akash1810 May 7, 2024 12:08
@mchv
Copy link
Member Author

mchv commented May 7, 2024

Ok, I think the workflow files need to be upgraded as well to run fine.

@mchv
Copy link
Member Author

mchv commented May 7, 2024

This now depends on https://github.com/guardian/riffraff-platform/pull/120

Copy link
Contributor

@NovemberTang NovemberTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We (me and @akash1810 ) tested this PR against galaxies, and found a few bits that are broken. Potentially there's some gaps in our CI here, but I think it makes sense to merge these in smaller chunks. We'll have another go at this later in the week.

@mchv
Copy link
Member Author

mchv commented May 13, 2024

@NovemberTang I think the main issue, was the same one I experienced on guardian/actions-read-private-repos#8. I will rebase and add missing bits.

@mchv
Copy link
Member Author

mchv commented May 14, 2024

Regarding the changes of ef06d4c we move from ts-node to tsx due to TypeStrong/ts-node#2094. Without that switch, cdk command will fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants