Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regen bindings #1775

Closed
wants to merge 1 commit into from
Closed

Regen bindings #1775

wants to merge 1 commit into from

Conversation

A6GibKm
Copy link
Contributor

@A6GibKm A6GibKm commented Jun 21, 2024

Using gtk-rs/gir-files#203

cc @bilelmoussaoui . Multiple things are not correct.

@A6GibKm
Copy link
Contributor Author

A6GibKm commented Jun 21, 2024

~~Wost offender is missing GtkResponseType.~~Fixed.

gtk4/src/auto/drag_icon.rs Outdated Show resolved Hide resolved
@@ -1325,7 +1327,6 @@ pub trait WidgetExt: IsA<Widget> + sealed::Sealed + 'static {
}

#[doc(alias = "gtk_widget_set_parent")]
#[doc(alias = "parent")]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property is not writable, hence this is correct.

@@ -110,7 +110,6 @@ impl MapListModel {
}

#[doc(alias = "gtk_map_list_model_set_model")]
#[doc(alias = "model")]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property is construct only, hence this also makes sense. Odd api.

@A6GibKm A6GibKm force-pushed the regen branch 5 times, most recently from 1481d99 to 9e05795 Compare June 22, 2024 12:29
@@ -4206,6 +4209,7 @@ extern "C" {
//=========================================================================
// GdkToplevelSize
//=========================================================================
pub fn gdk_toplevel_size_get_type() -> GType;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lacks v4_12 as it wasn't exposed before that causing build breaks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean manually?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah

@A6GibKm A6GibKm changed the title WIP: Regen bindings Regen bindings Jun 27, 2024
@A6GibKm
Copy link
Contributor Author

A6GibKm commented Jun 27, 2024

I just redid the MR without the GTK patch.

@bilelmoussaoui
Copy link
Member

Pushed a fixed version in #1792 , thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants