-
-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introducing "copy_terraform_lock_file" to fine tune Lock File Handling #2889
base: master
Are you sure you want to change the base?
Conversation
…andling Signed-off-by: Rodrigo Fior Kuntzer <[email protected]>
cc4a171
to
3ab235d
Compare
Hi @denis256, would you be so kind and provide some feedback about this PR? Thanks in advance. |
Hi, yes, it is in my queue to check... ⌛ |
Hi @denis256 , sorry to bother you once again, but is there anything I could help you to expedite the review of this PR? I would love to hear from you if this change is something the project is willing to accept. Thanks once again. |
hello @rodrigorfk @denis256 , hope you're doing well. Can I ask if this merge can be completed sometime soon? my team found this merge request and we could all use this feature since we're trying to create a remote and client setup for terragrunt and versioning could become an issue if there are locks on both remote and client side. |
# Conflicts: # cli/commands/terraform/action.go
488b2bf
to
2140d73
Compare
Hi @Josephuss , thanks for your message, I'm happy to see that your team also thought this change would be useful, I have updated the branch and fixed the outstanding conflicts. |
We've also come across this PR, it's exactly the functionality we need, for the same reasons as the others mentioned. |
Thanks @rodrigorfk for bringing this update! This change unlocks the ability for the lock file to be managed and versioned by the remove module itself. It would be great to have it merged. |
# Conflicts: # config/include_test.go # docs/_docs/02_features/lock-file-handling.md
Signed-off-by: Rodrigo Fior Kuntzer <[email protected]>
Thanks for the interest @IvanKuzyshyn , I have updated the branch and resolved the conflicts once again. Hopefully @denis256 will have some time to provide a feedback about this change soon. 🙏 |
Signed-off-by: Rodrigo Fior Kuntzer <[email protected]>
Quality Gate passedIssues Measures |
Description
Fixes #1653.
This PR introduces a new attribute called
copy_terraform_lock_file
under theterraform
block as following:The default value is
true
and does not change any existing Terragrunt behaviour, once it is defined asfalse
, Terragrunt will stop copying the.terraform.lock.hcl
file from the temporary terragrunt directory to the working directory.TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added / Removed / Updated [X].
Added "copy_terraform_lock_file" attribute to fine tune Lock File Handling
Migration Guide