Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate LC / LT to AWS SDK v2 #794

Closed

Conversation

sc250024
Copy link
Contributor

Description

Fixes #770.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Updated launch_template and launch_config to AWS SDK v2

@sc250024
Copy link
Contributor Author

Local results of tests:

git rev-parse HEAD
460b4ab4b825f5ecffd10895435938b68f33fe80go test -v -count=1 -parallel=10 -run "TestLaunchConfigurations_*" -run "TestLaunchTemplate_*" ./...
?   	github.com/gruntwork-io/cloud-nuke	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/gruntwork-io/cloud-nuke/aws	0.324s [no tests to run]
?   	github.com/gruntwork-io/cloud-nuke/externalcreds	[no test files]
?   	github.com/gruntwork-io/cloud-nuke/logging	[no test files]
?   	github.com/gruntwork-io/cloud-nuke/telemetry	[no test files]
=== RUN   TestLaunchTemplate_GetAll
=== PAUSE TestLaunchTemplate_GetAll
=== RUN   TestLaunchTemplate_NukeAll
=== PAUSE TestLaunchTemplate_NukeAll
=== CONT  TestLaunchTemplate_GetAll
=== CONT  TestLaunchTemplate_NukeAll
=== RUN   TestLaunchTemplate_GetAll/emptyFilter
--- PASS: TestLaunchTemplate_NukeAll (0.00s)
=== RUN   TestLaunchTemplate_GetAll/nameExclusionFilter
=== RUN   TestLaunchTemplate_GetAll/timeAfterExclusionFilter
--- PASS: TestLaunchTemplate_GetAll (0.00s)
    --- PASS: TestLaunchTemplate_GetAll/emptyFilter (0.00s)
    --- PASS: TestLaunchTemplate_GetAll/nameExclusionFilter (0.00s)
    --- PASS: TestLaunchTemplate_GetAll/timeAfterExclusionFilter (0.00s)
PASS
ok  	github.com/gruntwork-io/cloud-nuke/aws/resources	0.301s
?   	github.com/gruntwork-io/cloud-nuke/v2_migration_report	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/gruntwork-io/cloud-nuke/commands	0.548s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/gruntwork-io/cloud-nuke/config	0.695s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/gruntwork-io/cloud-nuke/report	0.846s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/gruntwork-io/cloud-nuke/ui	0.689s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/gruntwork-io/cloud-nuke/util	0.841s [no tests to run]

@wakeful
Copy link
Contributor

wakeful commented Nov 21, 2024

hey LC & LT was covered already in #792

@sc250024
Copy link
Contributor Author

hey LC & LT was covered already in #792

Ah you're right! I will close this then.

@sc250024 sc250024 closed this Nov 21, 2024
@sc250024 sc250024 deleted the chore-migrate-lc-lt-aws-sdk-v2 branch November 21, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to AWS SDKv2
2 participants