Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change port ec2 ipam byoasn, ec2 ipam custom allocation, ec2 ipam... #790

Merged

Conversation

wakeful
Copy link
Contributor

@wakeful wakeful commented Nov 18, 2024

Description

Fixes #770 update AWS SDK to v2 for

  • ec2 ipam byoasn
  • ec2 ipam custom allocation
  • ec2 ipam pool
  • ec2 ipam resource discovery
  • ec2 ipam scope
  • ec2 ipam

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

[x] Updated ec2 ipam byoasn, ec2 ipam custom allocation, ec2 ipam pool, ec2 ipam resource discovery, ec2 ipam scope, ec2 ipam to AWS SDK v2.

Migration Guide

n/a

…l, ec2 ipam resource discovery, ec2 ipam scope, ec2 ipam to awsSDKv2 gruntwork-io#770
Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall change LGTM. Waiting for tests result.

@james03160927 james03160927 merged commit 174aedb into gruntwork-io:master Nov 20, 2024
2 checks passed
@wakeful wakeful deleted the migrate-to-aws-sdk-v2-part-5 branch November 20, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to AWS SDKv2
2 participants