Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Snapshot to AWS SDK v2 #787

Merged

Conversation

sc250024
Copy link
Contributor

@sc250024 sc250024 commented Nov 15, 2024

Description

Fixes #770.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Updated snapshot to AWS SDK v2

Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Will trigger tests for this.

@sc250024
Copy link
Contributor Author

Overall LGTM. Will trigger tests for this.

@james03160927 I get the following locally:

go test -count=1 -parallel=10 ./...
?   	github.com/gruntwork-io/cloud-nuke	[no test files]
?   	github.com/gruntwork-io/cloud-nuke/externalcreds	[no test files]
?   	github.com/gruntwork-io/cloud-nuke/logging	[no test files]
?   	github.com/gruntwork-io/cloud-nuke/telemetry	[no test files]
ok  	github.com/gruntwork-io/cloud-nuke/aws	0.600s
?   	github.com/gruntwork-io/cloud-nuke/v2_migration_report	[no test files]
ok  	github.com/gruntwork-io/cloud-nuke/aws/resources	20.318s
ok  	github.com/gruntwork-io/cloud-nuke/commands	0.701s
ok  	github.com/gruntwork-io/cloud-nuke/config	0.449s
ok  	github.com/gruntwork-io/cloud-nuke/report	0.833s
ok  	github.com/gruntwork-io/cloud-nuke/ui	0.530s
ok  	github.com/gruntwork-io/cloud-nuke/util	0.675s

Ready to merge when you are!

@james03160927 james03160927 merged commit 988f95f into gruntwork-io:master Nov 18, 2024
2 checks passed
@sc250024 sc250024 deleted the chore-migrate-snap-aws-sdk-v2 branch November 20, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to AWS SDKv2
2 participants