Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-js: Add security connector, rework connection establishment #2855

Merged

Conversation

murgatroid99
Copy link
Member

This modifies the ChannelCredentials API so that instead of providing the connection options which are used to establish a TLS connection, it provides a SecurityConnector, which is created using information about a specific subchannel, and is responsible for establishing TLS connections on top of TCP connections.

With this change, the steps of establishing an HTTP/2 session are more cleanly divided:

  • The transport establishes the TCP connection, potentially delegating to the proxy connection code.
  • The security connector establishes the TLS connection on top of the TCP connection (or passes it through untouched, in the case of insecure credentials)
  • The transport creates the HTTP/2 session on top of the socket provided by the security connector.

@murgatroid99 murgatroid99 merged commit 8f08bbe into grpc:master Nov 23, 2024
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants