Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stats: deprecate trace and tags methods and remove all usages from internal code #7837

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

stats: deprecate trace and tags methods and remove all usages from internal code #7837

wants to merge 2 commits into from
+168 −65

Conversation

purnesh42H
Copy link
Contributor

@purnesh42H purnesh42H commented Nov 13, 2024 •
edited
Loading

Addresses: #7836

RELEASE NOTES:

  • stats: deprecated trace and tags methods and remove all usages from internal code

@purnesh42H purnesh42H changed the title stats: update trace methods to directly use metadata for header stats: update trace methods to directly set/get to and from grpc-trace-bin metadata header Nov 13, 2024
@purnesh42H purnesh42H added the Type: Internal Cleanup Refactors, etc label Nov 13, 2024
@purnesh42H purnesh42H added this to the 1.69 Release milestone Nov 13, 2024
@dfawley dfawley changed the title stats: update trace methods to directly set/get to and from grpc-trace-bin metadata header stats: update trace functions to directly use grpc-trace-bin metadata Nov 13, 2024
@purnesh42H purnesh42H assigned purnesh42H and unassigned dfawley Nov 13, 2024
@purnesh42H purnesh42H removed the request for review from dfawley November 13, 2024 21:20
@purnesh42H purnesh42H changed the title stats: update trace functions to directly use grpc-trace-bin metadata stats: deprecated stats.Trace and stats.SetTrace and update them to directly use grpc-trace-bin metadata Nov 13, 2024
@purnesh42H purnesh42H changed the title stats: deprecated stats.Trace and stats.SetTrace and update them to directly use grpc-trace-bin metadata stats: deprecated stats.Trace and stats.SetTrace and update them to directly access grpc-trace-bin metadata header Nov 13, 2024
@purnesh42H purnesh42H changed the title stats: deprecated stats.Trace and stats.SetTrace and update them to directly access grpc-trace-bin metadata header stats: deprecate trace and tags methods and remove all usages from internal code Nov 14, 2024
@purnesh42H purnesh42H force-pushed the modify-stats-package-to-handle-metadata branch from 0bc5140 to 9b581c2 Compare November 14, 2024 12:03
@codecov Codecov
Copy link

codecov bot commented Nov 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.04651% with 12 lines in your changes missing coverage. Please review.

Project coverage is 81.73%. Comparing base (0553bc3) to head (d4c3069).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
stats/stats.go 80.00% 8 Missing and 4 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7837      +/-   ##
==========================================
- Coverage   81.74%   81.73%   -0.02%     
==========================================
  Files         374      374              
  Lines       37931    38048     +117     
==========================================
+ Hits        31006    31097      +91     
- Misses       5621     5630       +9     
- Partials     1304     1321      +17
Files with missing lines Coverage Δ
internal/transport/http2_client.go 91.67% <100.00%> (-0.10%) ⬇️
internal/transport/http2_server.go 90.51% <100.00%> (-0.17%) ⬇️
stats/stats.go 73.33% <80.00%> (+1.90%) ⬆️

... and 23 files with indirect coverage changes

@purnesh42H purnesh42H force-pushed the modify-stats-package-to-handle-metadata branch from 9b581c2 to 1fcd73b Compare November 14, 2024 12:37
@purnesh42H purnesh42H force-pushed the modify-stats-package-to-handle-metadata branch from 1fcd73b to d4c3069 Compare November 14, 2024 12:37
@purnesh42H purnesh42H assigned dfawley and unassigned purnesh42H Nov 14, 2024
@purnesh42H purnesh42H mentioned this pull request Nov 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfawley dfawley Awaiting requested review from dfawley

At least 1 approving review is required to merge this pull request.

Assignees

@dfawley dfawley

Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.69 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@purnesh42H @dfawley