transport: add send operations to ClientStream and ServerStream #7808
+220
−229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More background refactoring work to potentially allow us to create an interceptor that can read raw bytes, and a couple very minor cleanups, too.
Next up I'm thinking of changing
ReadMessageHeader(buf)
(I foundReadHeader
ambiguous and confusing) andRead(n)
into a singleRead() (isCompressed bool, msgBytes mem.BufferSlice, err error)
. This means the transport needs to understand the grpc header and max message size configuration instead of the grpc layer, but that actually seems pretty straightforward and also appropriate.RELEASE NOTES: none