Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing date bug that was preventing requests. #23

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fixing date bug that was preventing requests. #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32b4818
fixing date bug that was preventing requests.
cowholio4 Jul 3, 2014
b57d72d
changing search to reflect API changes. groups are no longer returned
cowholio4 Jul 20, 2014
be12c4d
newer version of ruby and rails didn't like the syntax
cowholio4 Apr 4, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/foursquare/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ def initialize(args = {})
@access_token = args.fetch(:access_token, nil)
@client_id = args.fetch(:client_id, nil)
@client_secret = args.fetch(:client_secret, nil)
@api_version = args.fetch(:api_version, Date.new.strftime('%Y%m%d'))
@api_version = args.fetch(:api_version, Date.today.strftime('%Y%m%d'))

unless @access_token || (@client_id && @client_secret)
raise ArgumentError, "You need to pass either an access_token or client_id and client_secret"
Expand Down
12 changes: 3 additions & 9 deletions lib/foursquare/venue_proxy.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,8 @@ def find(id)

def search(options={})
raise ArgumentError, "You must include :ll" unless options[:ll]
response = @foursquare.get('venues/search', options)["groups"].inject({}) do |venues, group|
venues[group["type"]] ||= []
venues[group["type"]] += group["items"].map do |json|
Foursquare::Venue.new(@foursquare, json)
end
venues
response = @foursquare.get('venues/search', options)["venues"].map do |venue |
Foursquare::Venue.new(@foursquare, venue)
end
end

Expand All @@ -36,9 +32,7 @@ def nearby(options={})
def search_group(name, options)
raise ArgumentError, "You must include :ll" unless options[:ll]
response = @foursquare.get('venues/search', options)["groups"].detect { |group| group["type"] == name }
response ? response["items"].map do |json|
Foursquare::Venue.new(@foursquare, json)
end : []
response ? response["items"].map{ |json| Foursquare::Venue.new(@foursquare, json) } : []
end
end
end