Ebuilds updated for new Go version and recent Nvidia releases #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hunter L. Allen <[email protected]>
- Also split runtime into toolkit and runtime, as Nvidia has done.
- Gentoo has recently introduced and moved container related packages from the app-emulation to the app-containers category, so we're following suit. (also the ebuilds had to be updated anyway as the dependencies had already moved)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, first of all, thanks for your excellent overlay, which I have been using for the past year.
Recently Go updated to version 1.16, and with that the builds broke. I have updated all packages in the overlay to their most recent version released by Nvidia and also cleaned the ebuilds.
The Go ebuilds now use the go-module eclass, instead of relying on the Nvidia makefiles. Since nvidia-container-toolkit is now its own separate repo I've also split that package off into its own separate ebuild.
libnvidia-container now builds from source, as no binary releases have been made by Nvidia since the binary ebuild you provided. This required some hacking around the Git/Docker based makefile, but nothing too bad.
Finally no patches are needed anymore. nvidia-container-toolkit is solely a wrapper around runc which modifies the OCI spec, so no need to pull runc anymore and add a hook. nvidia-container-toolkit itself can be configured correctly for Gentoo through the config.toml file, which is now installed by the ebuild, setting the user:group pair correctly to "root:video".
Simplifications abound.
These changes have been based on the changes already made by Allen which provided a good starting point.
I have verified everything is working as it should. Including merging all packages from scratch after deinstalling them.
Cheers,
Bas