feat: a wider BaseArgType #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! First of all, awesome library 👏!
We are currently working on improving interop between TypeGPU and wgpu-matrix, and to do that, we plan to expose an
arrayViewproperty on our vectors and matrix primitives that gives access to the underlying data in the form of a flat array of numbers. Since its just a view, we only wanted to expose the necessities, like alengthproperty, and getters/setters for numeric properties. (Relevant issue)To make this possible, I was wondering if wgpu-matrix could have a wider type restriction, since it seems to operate solely on the
lengthprop and numeric properties.