no error #12
Closed
no error #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Super thanks for the PR. I'm sure I could spend time figuring out what this PR does but I would be super helpful if you had some time to explain what the issue was and what this PR is meant to fix. Also, it would be helpful if there was a test that was broken without this fix and that this fix fixes. |
|
Hi. It's kind of new stuff for me and it wasn't created to fix something in
your code.
I created a fork and I thought that made a pr which would not be visible to
you)
The problem is that error being thrown in getTextureInfo function because
of object for target is null in binding map.
My application is not WebGl error free and it is super hard to fix it. So
for my task it should be a workaround and will not change statistics
drastically.
Sorry for bothering.
…On Thu, 10 Aug 2023 at 02:52, Greggman ***@***.***> wrote:
I'm sure I could spend time figuring out what this PR does but I would be
super helpful if you had some time to explain what the issue was and what
this PR is meant to fix.
Also, it would be helpful if there was a test that was broken without this
fix and that this fix fixes.
—
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFZHTT3PR4TEHVVATLUPRATXUQPCNANCNFSM6AAAAAA3KBQJ2I>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.