Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upgrade to Angular v19 #3351

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion apps/daffio/server/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import 'zone.js/node';

import { APP_BASE_HREF } from '@angular/common';
import { CommonEngine } from '@angular/ssr';
import { CommonEngine } from '@angular/ssr/node';
import express from 'express';
import { existsSync } from 'node:fs';
import {
Expand Down
1 change: 1 addition & 0 deletions apps/daffio/src/app/app.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
templateUrl: './app.component.html',
styleUrls: ['./app.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
})

export class DaffioAppComponent {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { DaffioHomeCalloutPlatformsComponent } from './home-callout-platforms.co

@Component({
template: `<daffio-home-callout-platforms></daffio-home-callout-platforms>`,
standalone: false,
})
class WrapperComponent {}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
templateUrl: './home-callout-platforms.component.html',
styleUrls: ['./home-callout-platforms.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
})

export class DaffioHomeCalloutPlatformsComponent {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { DaffioHomeCalloutPwaComponent } from './home-callout-pwa.component';

@Component({
template: `<daffio-home-callout-pwa></daffio-home-callout-pwa>`,
standalone: false,
})
class WrapperComponent {}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
templateUrl: './home-callout-pwa.component.html',
styleUrls: ['./home-callout-pwa.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
})

export class DaffioHomeCalloutPwaComponent {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { DaffioHomeHeroComponent } from './home-hero.component';

@Component({
template: `<daffio-home-hero></daffio-home-hero>`,
standalone: false,
})
class WrapperComponent {}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import { DAFF_BRANDING_CONSTANTS } from '@daffodil/branding';
templateUrl: './home-hero.component.html',
styleUrls: ['./home-hero.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
})

export class DaffioHomeHeroComponent {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@ import {
templateUrl: './home-view.component.html',
styleUrls: ['./home-view.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
})
export class DaffioHomeViewComponent {}
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@ import {
templateUrl: './not-found.component.html',
styleUrls: ['./not-found.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
})
export class DaffioNotFoundComponent {}
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@ import {
templateUrl: './support.component.html',
styleUrls: ['./support.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
})
export class DaffioSupportComponent {}
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import {
templateUrl: './feature-comparison.component.html',
styleUrls: ['./feature-comparison.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
})
export class DaffioFeatureComparisonComponent {
faCheck = faCheck;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import { DaffioWhyPwaExamplesComponent } from './why-pwa-examples.component';

@Component({
template: `<daffio-why-pwa-examples></daffio-why-pwa-examples>`,
standalone: false,
})
class WrapperComponent {}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
templateUrl: './why-pwa-examples.component.html',
styleUrls: ['./why-pwa-examples.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
})

export class DaffioWhyPwaExamplesComponent {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { DaffioWhyPwaHeroComponent } from './why-pwa-hero.component';

@Component({
template: `<daffio-why-pwa-hero></daffio-why-pwa-hero>`,
standalone: false,
})
class WrapperComponent {}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
templateUrl: './why-pwa-hero.component.html',
styleUrls: ['./why-pwa-hero.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
})

export class DaffioWhyPwaHeroComponent {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import { DaffioWhyPwaOverviewComponent } from './why-pwa-overview.component';

@Component({
template: `<daffio-why-pwa-overview></daffio-why-pwa-overview>`,
standalone: false,
})
class WrapperComponent {}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import {
templateUrl: './why-pwa-overview.component.html',
styleUrls: ['./why-pwa-overview.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
})

export class DaffioWhyPwaOverviewComponent {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import { DaffioWhyPwaSolutionComponent } from './why-pwa-solution.component';

@Component({
template: `<daffio-why-pwa-solution></daffio-why-pwa-solution>`,
standalone: false,
})
class WrapperComponent {}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
templateUrl: './why-pwa-solution.component.html',
styleUrls: ['./why-pwa-solution.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
})

export class DaffioWhyPwaSolutionComponent {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import { DaffioWhyPwaStatsComponent } from './why-pwa-stats.component';

@Component({
template: `<daffio-why-pwa-stats></daffio-why-pwa-stats>`,
standalone: false,
})
class WrapperComponent {}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
templateUrl: './why-pwa-stats.component.html',
styleUrls: ['./why-pwa-stats.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
})

export class DaffioWhyPwaStatsComponent {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ import {
selector: 'daffio-why-pwa-view',
templateUrl: './why-pwa-view.component.html',
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
})
export class DaffioWhyPwaViewComponent {}
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import { DaffioFooterComponent } from './footer.component';

@Component({
template: `<daffio-footer></daffio-footer>`,
standalone: false,
})
class WrapperComponent { }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import { DAFF_BRANDING_CONSTANTS } from '@daffodil/branding';
templateUrl: './footer.component.html',
styleUrls: ['./footer.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
})
export class DaffioFooterComponent {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ import {
selector: 'daffio-marketing-footer',
templateUrl: './marketing-footer.component.html',
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
})
export class DaffioMarketingFooterComponent {}
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import { DaffioSimpleFooterComponent } from './simple-footer.component';

@Component({
template: `<daffio-simple-footer></daffio-simple-footer>`,
standalone: false,
})
class WrapperComponent { }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import { DAFF_BRANDING_CONSTANTS } from '@daffodil/branding';
templateUrl: './simple-footer.component.html',
styleUrls: ['./simple-footer.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
})
export class DaffioSimpleFooterComponent {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { DAFF_BRANDING_CONSTANTS } from '@daffodil/branding';
styleUrls: ['./sub-footer.component.scss'],
encapsulation: ViewEncapsulation.None,
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
})
export class DaffioSubFooterComponent {
@HostBinding('class.daffio-sub-footer') class = true;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { DaffioHeaderItemDirective } from './header-item.directive';

@Component({
template: `<a daffioHeaderItem [active]="active">Header Item</a>`,
standalone: false,
})
class WrapperComponent {
active: boolean;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {

@Directive({
selector: '[daffioHeaderItem]',
standalone: false,
})
export class DaffioHeaderItemDirective {
@HostBinding('class.daffio-header-item') class = true;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
templateUrl: './header.component.html',
styleUrls: ['./header.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
})

export class DaffioHeaderComponent {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import { DaffioNavLink } from '../link/type';

@Component({
template: '<daffio-nav-header-container></daffio-nav-header-container>',
standalone: true,
imports: [
DaffioNavHeaderContainer,
],
Expand Down
1 change: 0 additions & 1 deletion apps/daffio/src/app/core/nav/header/header.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ import { DaffioNavLink } from '../link/type';
templateUrl: './header.component.html',
styleUrls: ['./header.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: true,
imports: [
DaffioHeaderComponentModule,
RouterLink,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import { DaffioNavLink } from '../link/type';

@Component({
template: '<daffio-nav-header-container></daffio-nav-header-container>',
standalone: true,
imports: [
DaffioNavSidebarBodyComponent,
],
Expand Down
1 change: 0 additions & 1 deletion apps/daffio/src/app/core/nav/sidebar-body/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import { DaffioNavLink } from '../link/type';
templateUrl: './component.html',
styleUrls: ['./component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: true,
imports: [
AsyncPipe,
DAFF_LIST_COMPONENTS,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
templateUrl: './sidebar-footer.component.html',
styleUrls: ['./sidebar-footer.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
})
export class DaffioSidebarFooterComponent {
}
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { DaffioSidebarService } from '../../services/sidebar.service';
selector: 'daffio-sidebar-header',
templateUrl: './sidebar-header.component.html',
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
})
export class DaffioSidebarHeaderComponent {
faTimes = faTimes;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,10 @@ import {
import { DaffioSidebarViewportContainer } from './sidebar-viewport.component';
import { DaffioSidebarService } from '../../services/sidebar.service';

@Component({ template: '' })
@Component({
template: '',
standalone: false,
})
class TestComponent {}

describe('DaffioSidebarViewportContainer', () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import { DaffioSidebarService } from '../../services/sidebar.service';
templateUrl: './sidebar-viewport.component.html',
styleUrls: ['./sidebar-viewport.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
})
export class DaffioSidebarViewportContainer implements OnInit {
showSidebar: Signal<boolean>;
Expand Down
1 change: 1 addition & 0 deletions apps/daffio/src/app/core/template/template.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { DaffioRouterNamedViewsEnum } from '../router/named-views/models/named-v
templateUrl: './template.component.html',
styleUrls: ['./template.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
})
export class TemplateComponent {
readonly navNamedView = DaffioRouterNamedViewsEnum.NAV;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
templateUrl: './iphone.component.html',
styleUrls: ['./iphone.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
})
export class IphoneComponent{
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import { DaffioApiListSectionComponent } from './api-list-section.component';
template: `
<daffio-api-list-section [children]="apiListValue"></daffio-api-list-section>
`,
standalone: true,
imports: [
DaffioApiListSectionComponent,
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import { DaffApiNavDoc } from '@daffodil/docs-utils';
directive: DaffArticleEncapsulatedDirective,
}],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: true,
imports: [
RouterLink,
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@ import { DaffDocsApiNavList } from '@daffodil/docs-utils';
import { DaffioApiListComponent } from './api-list.component';
import { DaffioApiListSectionComponent } from '../api-list-section/api-list-section.component';

@Component({ template: '<daffio-api-list [apiList]="apiListValue"></daffio-api-list>' })
@Component({
template: '<daffio-api-list [apiList]="apiListValue"></daffio-api-list>',
standalone: false,
})
class WrapperComponent {
apiListValue: DaffDocsApiNavList = {
id: 'id',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { DaffDocsApiNavList } from '@daffodil/docs-utils';
templateUrl: './api-list.component.html',
styleUrls: ['./api-list.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
})
export class DaffioApiListComponent {
@HostBinding('class.daffio-api-list') class = true;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import { DaffioApiListSectionComponent } from '../api-list-section/api-list-sect
template: `
<daffio-api-package [doc]="apiListValue"></daffio-api-package>
`,
standalone: true,
imports: [
DaffioApiPackageComponent,
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import { DaffioApiListSectionComponent } from '../api-list-section/api-list-sect
directive: DaffArticleEncapsulatedDirective,
}],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: true,
imports: [
RouterLink,
DaffioApiListSectionComponent,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import { DaffioApiListComponent } from '../../components/api-list/api-list.compo
@Component({
template: '',
selector: 'daffio-api-list',
standalone: false,
})
class MockDaffioApiListComponent {
@Input() apiList: DaffDocsApiNavList[] = [];
Expand Down
Loading
Loading