-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(daffio): create packages sidebar #2725
Conversation
a73c145
to
91ab4fc
Compare
@xelaint lmk what you think about the updated behavior |
@griest024 The sidebar header and footer is visible on the I feel like splitting up the sidebars into three separate named views is part of issue? |
@elainoo what should the header and footer be in the |
91ab4fc
to
f64c061
Compare
@xelaint I added the header and footer, LMK if this is what you want |
@griest024 Close, but the package sidebar header and footer should be hidden while the package sidebar is still in |
f64c061
to
d15db5a
Compare
@xelaint changed. Note that the "get started" footer shows for the packages list sidebar when opened as the "content" sidebar, IDK if this is what you want. There's also a failing test that I need to look at later but the implementation is ready for you to look at. |
b24e1f4
to
891597e
Compare
@griest024 I think this PR is good to go for now, but questions for future implementation:
|
@xelaint would |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
No specific sidebar for packages.
Part of: #2682
What is the new behavior?
There is a packages sidebar now that should be rendered within the
/packages/..
pages.TODO:
Does this PR introduce a breaking change?
Other information