-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new gv-select-native component #493
Conversation
b4bd769
to
2f93ad3
Compare
2f93ad3
to
b014eb3
Compare
Gravitee.io Automatic Deployment A beta version of this package has been published! 🚀 This is still experimental To use it in your project run the following lines: echo @gravitee-io:registry=https://npm.pkg.github.com > .npmrc
npm install @gravitee-io/[email protected]
rm -rf node_modules/@gravitee
mv node_modules/@gravitee-io node_modules/@gravitee |
b014eb3
to
5aa92ce
Compare
Gravitee.io Automatic Deployment A beta version of this package has been published! 🚀 This is still experimental To use it in your project run the following lines: echo @gravitee-io:registry=https://npm.pkg.github.com > .npmrc
npm install @gravitee-io/[email protected]
rm -rf node_modules/@gravitee
mv node_modules/@gravitee-io node_modules/@gravitee |
5aa92ce
to
8217140
Compare
Gravitee.io Automatic Deployment A beta version of this package has been published! 🚀 This is still experimental To use it in your project run the following lines: echo @gravitee-io:registry=https://npm.pkg.github.com > .npmrc
npm install @gravitee-io/[email protected]
rm -rf node_modules/@gravitee
mv node_modules/@gravitee-io node_modules/@gravitee |
8217140
to
28d32c1
Compare
Gravitee.io Automatic Deployment A beta version of this package has been published! 🚀 This is still experimental To use it in your project run the following lines: echo @gravitee-io:registry=https://npm.pkg.github.com > .npmrc
npm install @gravitee-io/[email protected]
rm -rf node_modules/@gravitee
mv node_modules/@gravitee-io node_modules/@gravitee |
28d32c1
to
ccbcc47
Compare
Gravitee.io Automatic Deployment A beta version of this package has been published! 🚀 This is still experimental To use it in your project run the following lines: echo @gravitee-io:registry=https://npm.pkg.github.com > .npmrc
npm install @gravitee-io/[email protected]
rm -rf node_modules/@gravitee
mv node_modules/@gravitee-io node_modules/@gravitee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The behaviour when the multiple
attribute is selected matches the one from the HTML default select (https://www.w3schools.com/tags/att_select_multiple.asp) but is quite strange. We need to discuss that with the team. Otherwise it looks good 🚀
ccbcc47
to
4c7cf27
Compare
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
Gravitee.io Automatic Deployment A beta version of this package has been published! 🚀 This is still experimental To use it in your project run the following lines: echo @gravitee-io:registry=https://npm.pkg.github.com > .npmrc
npm install @gravitee-io/[email protected]
rm -rf node_modules/@gravitee
mv node_modules/@gravitee-io node_modules/@gravitee |
🎉 This PR is included in version 3.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Issue
#251
#329
gravitee-io/issues#6487
Sorry for the duplication...
I kept the
<gv-select>
to not create a breaking change and for the storyTransparentOnDarkBackground
which can't be reimplemented correctly with this new component.Later, it would be nice to turn the
gv-select
into agv-listbox
or something like that, letting users build the list via theslot
, this would allow better customization and data event binding possibilities.