Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new gv-select-native component #493

Merged
merged 5 commits into from
Nov 16, 2021
Merged

add new gv-select-native component #493

merged 5 commits into from
Nov 16, 2021

Conversation

gcusnieux
Copy link
Member

@gcusnieux gcusnieux commented Nov 3, 2021

Issue

#251
#329
gravitee-io/issues#6487

Sorry for the duplication...
I kept the <gv-select> to not create a breaking change and for the story TransparentOnDarkBackground which can't be reimplemented correctly with this new component.
Later, it would be nice to turn the gv-select into a gv-listbox or something like that, letting users build the list via the slot, this would allow better customization and data event binding possibilities.

@gcusnieux gcusnieux force-pushed the 251-native-gv-select branch from b4bd769 to 2f93ad3 Compare November 5, 2021 17:41
@gcusnieux gcusnieux changed the title refactor(gv-select): switch to native select add new gv-select-native component Nov 5, 2021
@gcusnieux gcusnieux force-pushed the 251-native-gv-select branch from 2f93ad3 to b014eb3 Compare November 5, 2021 17:43
@graviteeio
Copy link
Contributor

Gravitee.io Automatic Deployment

A beta version of this package has been published! 🚀

This is still experimental ⚠️

To use it in your project run the following lines:

echo @gravitee-io:registry=https://npm.pkg.github.com > .npmrc
npm install @gravitee-io/[email protected]
rm -rf node_modules/@gravitee
mv node_modules/@gravitee-io node_modules/@gravitee

@gcusnieux gcusnieux force-pushed the 251-native-gv-select branch from b014eb3 to 5aa92ce Compare November 6, 2021 08:23
@graviteeio
Copy link
Contributor

Gravitee.io Automatic Deployment

A beta version of this package has been published! 🚀

This is still experimental ⚠️

To use it in your project run the following lines:

echo @gravitee-io:registry=https://npm.pkg.github.com > .npmrc
npm install @gravitee-io/[email protected]
rm -rf node_modules/@gravitee
mv node_modules/@gravitee-io node_modules/@gravitee

@gcusnieux gcusnieux marked this pull request as ready for review November 6, 2021 08:32
@gcusnieux gcusnieux requested review from a team November 6, 2021 08:32
@gcusnieux gcusnieux force-pushed the 251-native-gv-select branch from 5aa92ce to 8217140 Compare November 8, 2021 11:26
@graviteeio
Copy link
Contributor

Gravitee.io Automatic Deployment

A beta version of this package has been published! 🚀

This is still experimental ⚠️

To use it in your project run the following lines:

echo @gravitee-io:registry=https://npm.pkg.github.com > .npmrc
npm install @gravitee-io/[email protected]
rm -rf node_modules/@gravitee
mv node_modules/@gravitee-io node_modules/@gravitee

@gcusnieux gcusnieux changed the title add new gv-select-native component [WIP] add new gv-select-native component Nov 10, 2021
@gcusnieux gcusnieux force-pushed the 251-native-gv-select branch from 8217140 to 28d32c1 Compare November 15, 2021 13:51
@gcusnieux gcusnieux changed the title [WIP] add new gv-select-native component add new gv-select-native component Nov 15, 2021
@graviteeio
Copy link
Contributor

Gravitee.io Automatic Deployment

A beta version of this package has been published! 🚀

This is still experimental ⚠️

To use it in your project run the following lines:

echo @gravitee-io:registry=https://npm.pkg.github.com > .npmrc
npm install @gravitee-io/[email protected]
rm -rf node_modules/@gravitee
mv node_modules/@gravitee-io node_modules/@gravitee

@gcusnieux gcusnieux force-pushed the 251-native-gv-select branch from 28d32c1 to ccbcc47 Compare November 15, 2021 13:56
@graviteeio
Copy link
Contributor

Gravitee.io Automatic Deployment

A beta version of this package has been published! 🚀

This is still experimental ⚠️

To use it in your project run the following lines:

echo @gravitee-io:registry=https://npm.pkg.github.com > .npmrc
npm install @gravitee-io/[email protected]
rm -rf node_modules/@gravitee
mv node_modules/@gravitee-io node_modules/@gravitee

Copy link
Contributor

@gaetanmaisse gaetanmaisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behaviour when the multiple attribute is selected matches the one from the HTML default select (https://www.w3schools.com/tags/att_select_multiple.asp) but is quite strange. We need to discuss that with the team. Otherwise it looks good 🚀

src/atoms/gv-select.js Outdated Show resolved Hide resolved
src/atoms/gv-select-native.js Outdated Show resolved Hide resolved
@gcusnieux gcusnieux force-pushed the 251-native-gv-select branch from ccbcc47 to 4c7cf27 Compare November 16, 2021 09:49
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
16.2% 16.2% Duplication

@graviteeio
Copy link
Contributor

Gravitee.io Automatic Deployment

A beta version of this package has been published! 🚀

This is still experimental ⚠️

To use it in your project run the following lines:

echo @gravitee-io:registry=https://npm.pkg.github.com > .npmrc
npm install @gravitee-io/[email protected]
rm -rf node_modules/@gravitee
mv node_modules/@gravitee-io node_modules/@gravitee

@gcusnieux gcusnieux merged commit 92f6479 into master Nov 16, 2021
@gcusnieux gcusnieux deleted the 251-native-gv-select branch November 16, 2021 10:03
@graviteeio
Copy link
Contributor

🎉 This PR is included in version 3.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants