Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: evaluate session state before FORM rendering and submission #5154

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leleueri
Copy link
Contributor

a new attribute has been added to the session to determine if the session is ongoing or not

if it is actions related to a form are executed as usual

if it is not a redirect to authorization endpoint is perform to follow the auth flow

this is to avoid issues when a user is fully authenticated but use the back arraow on the browser

this solution is not perfect as a back click before the end of the auth flow

will not skip the page rendering

fixes AM-4342

@leleueri leleueri requested a review from a team as a code owner November 20, 2024 13:57
@leleueri leleueri force-pushed the am-4342 branch 2 times, most recently from 660e729 to 16d6db1 Compare November 22, 2024 13:23
 a new attribute has been added to the session to determine if the session is ongoing or not

 if it is actions related to a form are executed as usual

 if it is not a redirect to authorization endpoint is perform to follow the auth flow

 this is to avoid issues when a user is fully authenticated but use the back arraow on the browser

 this solution is not perfect as a back click before the end of the auth flow

 will not skip the page rendering

fixes AM-4342
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
13.64% Condition Coverage on New Code (required ≥ 50%)

See analysis details on SonarQube Cloud

@leleueri leleueri marked this pull request as draft December 19, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants