build: Require ENVIRONMENT_NAME for darwin signing on CI #49105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camscale
added
the
no-changelog
When running the build on CI, require that the `ENVIRONMENT_NAME` environment var is set, and only default to `build-stage` if we are not on CI. This can help catch this var missing on CI while still in staging and not when we try a production release.
camscale
force-pushed
the
camh/require-env-name
branch
from
f6e31f6
to
8257651
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the build on CI, require that the
ENVIRONMENT_NAMEenvironment var is set, and only default to
build-stageif we are noton CI. This can help catch this var missing on CI while still in staging
and not when we try a production release.
This a draft while I complete some testing to ensure it does not break the
build.