Start autoupdate_agent_rollout controller in auth service
#49101
+169
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoShaka
added
the
no-changelog
hugoShaka
force-pushed
the
hugo/add-autoupdate-agent-rollout-controller
branch
from
f611f35
to
1042ef7
Compare
rosstimothy
reviewed
Nov 15, 2024
Comment on lines
+1879
to
+1880
| require.NoError(t, process.Start()) | ||
| t.Cleanup(func() { require.NoError(t, process.Close()) }) |
There was a problem hiding this comment.
FYI without waiting for all the services to complete this test could be susceptible to flakiness caused by clean up of the data directory while Teleport components may still be running. See #49050.
rosstimothy
reviewed
Nov 15, 2024
| // See the reconciler godoc for more details about the reconciliation process. | ||
| // We currently wake up every minute, in the future we might decide to also watch for events | ||
| // (from autoupdate_config and autoupdate_version changefeed) to react faster. | ||
| type Controller struct { |
There was a problem hiding this comment.
nit: Avoid repetition (rolloutcontroller.Controller), either by renaming this type or changing the package to rollout or something similar.
vapopov
reviewed
Nov 15, 2024
| Jitter: retryutils.SeventhJitter, | ||
| Clock: c.clock, | ||
| } | ||
| ticker := interval.New(config) |
There was a problem hiding this comment.
Suggested change
| ticker := interval.New(config) | |
| ticker := interval.New(config) | |
| defer ticker.Stop() |
vapopov
reviewed
Nov 15, 2024
| clt: client, | ||
| log: log, | ||
| } | ||
|
|
||
| // Test execution: run the reconciliation loop | ||
| require.ErrorContains(t, reconciler.Reconcile(cancelableCtx), "canceled") | ||
| require.ErrorContains(t, reconciler.reconcile(cancelableCtx), "canceled") |
There was a problem hiding this comment.
nit:
Suggested change
| require.ErrorContains(t, reconciler.reconcile(cancelableCtx), "canceled") | |
| require.ErrorIs(t, reconciler.reconcile(cancelableCtx), context.Canceled) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the autoupdate_agent_rollout controller and starts it when we run as the auth service.
This also makes the Reconciler type private as there is currently no usage outside of the Controller.