Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature add the possibility to send pcic commands #17

Merged
merged 6 commits into from
Jul 11, 2024

Conversation

graugans
Copy link
Owner

@graugans graugans commented Jul 5, 2024

This will allow the user to send commands like C?, p0 or even to change the output with the c command

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 4.88889% with 214 lines in your changes missing coverage. Please review.

Project coverage is 22.95%. Comparing base (b5ee90a) to head (a17a4f5).
Report is 3 commits behind head on v2.

Files Patch % Lines
pkg/pcic/protocol.go 11.00% 85 Missing and 4 partials ⚠️
pkg/swupdater/swupdater.go 0.00% 50 Missing ⚠️
cmd/ovp8xx/cmd/pcic.go 0.00% 44 Missing ⚠️
cmd/ovp8xx/cmd/swupdate.go 0.00% 31 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2      #17      +/-   ##
==========================================
- Coverage   26.45%   22.95%   -3.51%     
==========================================
  Files          22       22              
  Lines        1096     1298     +202     
==========================================
+ Hits          290      298       +8     
- Misses        805      995     +190     
- Partials        1        5       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@graugans graugans merged commit ad0749c into v2 Jul 11, 2024
8 checks passed
@graugans graugans deleted the feature/pcic-commands branch July 11, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants