Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update cspell.yml #1100

Merged
merged 2 commits into from
Jun 10, 2024
Merged

chore: Update cspell.yml #1100

merged 2 commits into from
Jun 10, 2024

Conversation

Jason3S
Copy link
Contributor

@Jason3S Jason3S commented Jun 10, 2024

The current cspell.yml file doesn't parse.

!!! IMPORTANT !!!

Please Read https://github.com/graphql/graphql-spec/blob/master/CONTRIBUTING.md
before creating a Pull Request.

@Jason3S
fix: Update cspell.yml
c475013 
The current cspell.yml file doesn't parse.
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jun 10, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: benjie / name: Benjie (bd6231a)
  • ✅ login: Jason3S / name: Jason Dent (c475013)

@netlify Netlify
Copy link

netlify bot commented Jun 10, 2024 •
edited
Loading

✅ Deploy Preview for graphql-spec-draft ready!

Name Link
🔨 Latest commit bd6231a
🔍 Latest deploy log https://app.netlify.com/sites/graphql-spec-draft/deploys/6666ef7bba848e00087f64c0
😎 Deploy Preview https://deploy-preview-1100--graphql-spec-draft.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jason3S
Copy link
Contributor Author

Jason3S commented Jun 10, 2024

Hello @benjie,

Two things:

  1. I noticed that the latest changes to cspell.yml do not parse as correct Yaml. This PR is to address that. This fix includes one of the newer CSpell features to make suggestions on the desired spelling. An alternative fix is to just surround - !implementor and - !implementors with quotes: - '!implementor'.
  2. The version of CSpell is quite old. Is there a reason to stay on v5?

@Jason3S Jason3S changed the title fix: Update cspell.yml chore: Update cspell.yml Jun 10, 2024
@Jason3S Jason3S mentioned this pull request Jun 10, 2024
Merged
benjie
benjie approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch; thanks!

cspell.yml Outdated Show resolved Hide resolved
@benjie benjie merged commit f8f2fac into graphql:main Jun 10, 2024
7 of 8 checks passed
@benjie
Copy link
Member

benjie commented Jun 10, 2024

The version of CSpell is quite old. Is there a reason to stay on v5?

Not particularly. No particular need to upgrade either though.

@319684023 319684023 mentioned this pull request Jun 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjie benjie benjie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jason3S @benjie